-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use armv6t2 instead of armv6 #149
Conversation
Is there a way to disable both the thumbs? If not, then this seems like an obvious sol'n to me. |
I have no idea. Gcc accepts |
This comment seems quite relevent perhaps? Currently |
So I tried to use a number of options to see if any of them would remove the define for thumb, sadly none of them except redefining the environment variable manually helped:
This is how I was testing it:
So I suppose simply adding this define for our own compiler-rt compilation is the way to go, leaving gcc-rs alone. |
A small aside, I read a recommendation in multiple locations that if thumb2 is not available, |
Using a different fix for now ( |
@TimNN |
This is required to correctly build
compiler-rt
of rust-lang/rust with LLVM 4.0.I don't know what exactly the consequences of this change are, however in general
armv6t2
seems to be widely supported. However note that the raspberry pi 1, for example, apparently does not support Thumb 2. See also the Wikipedia List of ARM Microarchitectures.cc @nagisa: You have done some research into this as well, I believe.
cc rust-lang/rust#40123